Skip to content

Conversation

MichaelDeutschCoding
Copy link
Contributor

Fix the sample output for the snippet in ConsoleKey1.cs to match the code.

Summary

The sample output for the snippet did not match the described code (the code would print "together with" while the sample output said "along with").

  • Fixed the sample output to match the snippet code
  • Changed to use Enum.HasFlag() instead of bit masking for easier readability

Fix the sample output for the snippet in ConsoleKey1.cs to match the code.
@MichaelDeutschCoding MichaelDeutschCoding requested a review from a team as a code owner May 15, 2023 15:39
@ghost ghost added community-contribution Indicates that the PR has been added by a community member area-System.Runtime labels May 15, 2023
@learn-build-service-prod
Copy link

Learn Build status updates of commit aea052a:

✅ Validation status: passed

File Status Preview URL Details
snippets/csharp/System/ConsoleKey/Overview/ConsoleKey1.cs ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@BillWagner
Copy link
Member

Hi @MichaelDeutschCoding

I looked at the changes, and these look great to me. Once you accept the Contributor License Agreement (CLA), I'll :shipit:

@BillWagner BillWagner enabled auto-merge (squash) May 16, 2023 14:42
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM. Setting to auto-merge once the CLA check passes.

@MichaelDeutschCoding
Copy link
Contributor Author

@dotnet-policy-service agree

@BillWagner BillWagner merged commit 546ce89 into dotnet:main May 16, 2023
@MichaelDeutschCoding MichaelDeutschCoding deleted the patch-1 branch May 18, 2023 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area-System.Runtime community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants